Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with more than one parameterless constructor #55824

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Aug 23, 2021

Fixes #55797
Fixes #55794

I reviewed other usages of InstanceConstructors and didn't find other problematic call-sites.

Relates to test plan #51698

@jcouv jcouv self-assigned this Aug 23, 2021
@jcouv jcouv marked this pull request as ready for review August 23, 2021 20:41
@jcouv jcouv requested a review from a team as a code owner August 23, 2021 20:41
@jcouv
Copy link
Member Author

jcouv commented Aug 23, 2021

@cston @RikkiGibson @dotnet/roslyn-compiler for review. Small bug fix. Thanks

@cston
Copy link
Member

cston commented Aug 23, 2021

    {

Should this return false immediately if !type.IsValueType?


In reply to: 904139127


In reply to: 904139127


Refers to: src/Compilers/CSharp/Portable/Symbols/MemberSymbolExtensions.cs:405 in cfa89c9. [](commit_id = cfa89c9, deletion_comment = False)

@jcouv jcouv enabled auto-merge (squash) August 24, 2021 19:08
@jcouv jcouv merged commit 2238b15 into dotnet:main Aug 24, 2021
@ghost ghost added this to the Next milestone Aug 24, 2021
@jcouv jcouv deleted the two-ctors branch August 24, 2021 19:51
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Garbage base clause causes compiler crash Language services crashed when editing .NET Runtime project
5 participants