Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report an error for a misplaced :: token. #55828

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Report an error for a misplaced :: token. #55828

merged 1 commit into from
Aug 24, 2021

Conversation

AlekseyTs
Copy link
Contributor

Fixes #53021.

@AlekseyTs AlekseyTs requested a review from a team as a code owner August 23, 2021 22:49
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review a small bug fix.

333fred
333fred approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1). I'm curious: what did we treat the :: as previously? A ., effectively?

@AlekseyTs
Copy link
Contributor Author

I'm curious: what did we treat the :: as previously? A ., effectively?

Correct.

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For a second review for a small bug fix.

@AlekseyTs AlekseyTs merged commit 94cb8ed into dotnet:main Aug 24, 2021
@ghost ghost added this to the Next milestone Aug 24, 2021
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.

A syntax error is missing for a misplaced ColonColon token in explicit interface implementation.
4 participants
@AlekseyTs @333fred @RikkiGibson @dibarbet