Check CS0103 when try to replace type cast by 'is' pattern #55864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #51340
In code sample
When we search the potential match for
aGenericThing
,let specificThing = (SpecificThingType)aGenericThing
is included.However, when the analyzer is trying to apply
aGenericThing is SpecificThingType Baz
in the WhereClauseit is unsafe to replace
(SpecificThingType)aGenericThing
withBaz
.So add an extra diagnostic check for CS0103