Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnC - Report diagnostic when compiler synthesizes new types on unsupported runtime #55876

Merged
merged 3 commits into from
Aug 25, 2021
Merged

EnC - Report diagnostic when compiler synthesizes new types on unsupported runtime #55876

merged 3 commits into from
Aug 25, 2021

Conversation

davidwengier
Copy link
Contributor

Fixes #54676

Could follow up with more specific rude edit based diagnostics for specific scenarios, but I like this as a safety net to catch them all.

@davidwengier davidwengier requested a review from tmat August 25, 2021 03:54
@davidwengier davidwengier requested a review from a team as a code owner August 25, 2021 03:54
ryzngard
ryzngard approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed,
Someone who only knows a little about EnC

src/Features/Core/Portable/EditAndContinue/EditSession.cs Outdated Show resolved Hide resolved
src/Features/Core/Portable/EditAndContinue/EditSession.cs Outdated Show resolved Hide resolved
src/EditorFeatures/Test/EditAndContinue/EditAndContinueWorkspaceServiceTests.cs Show resolved Hide resolved
@davidwengier @ryzngard
Update src/Features/Core/Portable/EditAndContinue/EditSession.cs
d39029c 
Co-authored-by: Andrew Hall <ryzngard@live.com>
@davidwengier davidwengier changed the title Report diagnostic when compiler synthesizes new types on unsupported runtime EnC - Report diagnostic when compiler synthesizes new types on unsupported runtime Aug 25, 2021
tmat
tmat reviewed Aug 25, 2021
View reviewed changes
src/Features/Core/Portable/EditAndContinue/EditAndContinueErrorCode.cs Outdated
@@ -12,5 +12,6 @@ internal enum EditAndContinueErrorCode
ChangesDisallowedWhileStoppedAtException = 4,
DocumentIsOutOfSyncWithDebuggee = 5,
UnableToReadSourceFileOrPdb = 6,
ChangeResultsInSynthesizedType = 7,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeResultsInSynthesizedType

The name does not indicate that it's runtime-specific limitation. Maybe RuntimeMustSupportAddingTypes or AddingTypeRuntimeCapabilityRequired?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like AddingTypeRuntimeCapabilityRequired, thanks

tmat
tmat approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier enabled auto-merge (squash) August 25, 2021 23:22
@davidwengier davidwengier merged commit 18556e8 into dotnet:main Aug 25, 2021
@ghost ghost added this to the Next milestone Aug 25, 2021
@davidwengier davidwengier deleted the EnCDiagnosticForNewTypes branch August 26, 2021 01:00
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.0.P4
4 participants
@davidwengier @tmat @ryzngard @dibarbet