Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IEditAndContinueSolutionProvider #55889

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Add IEditAndContinueSolutionProvider #55889

merged 1 commit into from
Aug 26, 2021

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 25, 2021 •
edited
Loading

Implements #55683

@tmat tmat requested a review from a team as a code owner August 25, 2021 17:40
@tmat
Copy link
Member Author

tmat commented Aug 25, 2021

@spadapet #55717 is blocked on debugger changes that I'm not sure when we can get it.
You should be unblocked by this change. In Microsoft.VisualStudio.LanguageServices.Xaml you should be able to MEF-import IEnumerable<IEditAndContinueSolutionProvider> and subscribe to the event on all providers. Currently there is one for EnC and one for Hot Reload. They will be unified later (by #55717) and I'll update the code as necessary at that point.

@tmat
Copy link
Member Author

tmat commented Aug 25, 2021

@davidwengier PTAL

@spadapet
Copy link
Contributor

@spadapet #55717 is blocked on debugger changes that I'm not sure when we can get it.
You should be unblocked by this change. In Microsoft.VisualStudio.LanguageServices.Xaml you should be able to MEF-import IEnumerable<IEditAndContinueSolutionProvider> and subscribe to the event on all providers. Currently there is one for EnC and one for Hot Reload. They will be unified later (by #55717) and I'll update the code as necessary at that point.

Thanks @tmat I'll try this out after it's complete.

@tmat tmat merged commit 7e51135 into dotnet:main Aug 26, 2021
@ghost ghost added this to the Next milestone Aug 26, 2021
@tmat tmat deleted the IEditAndContinueSolutionProvider branch August 26, 2021 18:39
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
@tmat tmat mentioned this pull request Sep 15, 2021
Closed
@spadapet spadapet mentioned this pull request Nov 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Interactive
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @spadapet @davidwengier @dibarbet