Set resources correctly on CopyRefAssembly #55893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to other tasks we fixed previously we need to ensure that resources are set correctly when creating the `CopyRefAssembly` task. The only correct way to do this is pass the `ResourceManager` through the constructor. Follow up of dotnet#52836 Related to dotnet/msbuild#6253
|
@dotnet/roslyn-compiler PTAL |
rainersigwald
approved these changes
Aug 25, 2021
cston
reviewed
Aug 25, 2021
| using Microsoft.Build.Framework; | ||
| using Microsoft.CodeAnalysis.BuildTasks; | ||
| using Xunit; | ||
| using Moq; |
cston
approved these changes
Aug 25, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other tasks we fixed previously we need to ensure that
resources are set correctly when creating the
CopyRefAssemblytask.The only correct way to do this is pass the
ResourceManagerthroughthe constructor.
Follow up of #52836
Related to dotnet/msbuild#6253