Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove top level attributes on MoveTypeToFile #55900

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Remove top level attributes on MoveTypeToFile #55900

merged 2 commits into from
Aug 26, 2021

Conversation

ryzngard
Copy link
Contributor

Fixes #55544

@ryzngard ryzngard requested a review from a team as a code owner August 25, 2021 22:43
CyrusNajmabadi
CyrusNajmabadi approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i approve with a little beefed up testing. have the same tests without a namespcae, and have tests with/without namespace with attributes on the class being moved (also, please have hte class being moved be first in the file).

@ryzngard ryzngard merged commit b11adaa into dotnet:main Aug 26, 2021
@ghost ghost added this to the Next milestone Aug 26, 2021
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@davidwengier davidwengier davidwengier approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.

Move to type to file duplicates attribute
5 participants
@ryzngard @JoeRobich @davidwengier @CyrusNajmabadi @dibarbet