Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify forbidden zone for foreach deconstruction variables. #55982

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Specify forbidden zone for foreach deconstruction variables. #55982

merged 1 commit into from
Aug 30, 2021

Conversation

AlekseyTs
Copy link
Contributor

Fixes #46165.

@AlekseyTs AlekseyTs requested a review from jcouv August 27, 2021 23:25
@AlekseyTs AlekseyTs requested a review from a team as a code owner August 27, 2021 23:25
jcouv
jcouv approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Aug 28, 2021
@AlekseyTs AlekseyTs enabled auto-merge (squash) August 30, 2021 15:06
@AlekseyTs AlekseyTs merged commit ff6ef22 into dotnet:main Aug 30, 2021
@ghost ghost added this to the Next milestone Aug 30, 2021
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.

Reproducible VS crash when writing a foreach statement with tuple type inference
4 participants
@AlekseyTs @cston @jcouv @dibarbet