Skip to content

Conversation

@kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Aug 28, 2021

@kzrnm kzrnm requested a review from a team as a code owner August 28, 2021 06:14
@kzrnm kzrnm requested a review from a team August 28, 2021 06:14
@ghost ghost added the Area-IDE label Aug 28, 2021
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Sep 2, 2021
@ryzngard
Copy link
Contributor

ryzngard commented Sep 2, 2021

Thanks for contributing @naminodarie . This change looks good in that improves the user experience by providing an error pop up instead of a yellow bar. I think we should take this. However, it doesn't fix the underlying issue. In my investigation it appears to be related to trying to rename a file that is in a .csproj with relative pathing, such as ../MyFile.cs. We'll want to investigate that issue as well before closing as fixed

@ryzngard ryzngard merged commit c5ce2d5 into dotnet:main Sep 2, 2021
@ghost ghost added this to the Next milestone Sep 2, 2021
@kzrnm kzrnm deleted the rename_return branch September 2, 2021 09:38
@Cosifne Cosifne modified the milestones: Next, 17.0.P5 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F2 Rename Apply is inconsistent

4 participants