Don't reference VS Shell binaries in EditorFeatures.Wpf #56045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Aug 31, 2021
JoeRobich
approved these changes
Aug 31, 2021
ryzngard
reviewed
Aug 31, 2021
| ViewIncludesBufferFromWorkspace(_textView, _renameService.ActiveSession.Workspace)) | ||
| { | ||
| _dashboardColorUpdater?.UpdateColors(); | ||
|
|
Contributor
There was a problem hiding this comment.
Does this work with theme updates after opening?
Member
Author
There was a problem hiding this comment.
Yes, since the thing we're passing around here is the keys, not the colors/brushes themselves. Turns out that's what makes the other approaches difficult -- it's not just the values that are dynamic, but the keys themselves.
jasonmalinowski
force-pushed
the
fix-editorfeatures.wpf-layering
branch
from
d26c2d7 to
492d172
Compare
jasonmalinowski
force-pushed
the
fix-editorfeatures.wpf-layering
branch
from
492d172 to
9e1df28
Compare
EditorFeatures.Wpf is supposed to be independent of the VS Shell, the idea is this layer can be hosted in other applications using the VS editor but not VS itself. This re-adds indirection for fetching the dashboard colors, but now only does it when the dashboard is opened. While I was here I ended up renaming CodeAnalysisColors to DashboardColors which is a bit clearer what it is.
jasonmalinowski
force-pushed
the
fix-editorfeatures.wpf-layering
branch
from
9e1df28 to
074fe49
Compare
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorFeatures.Wpf is supposed to be independent of the VS Shell, the idea is this layer can be hosted in other applications using the VS editor but not VS itself. This re-adds indirection for fetching the dashboard colors, but now only does it when the dashboard is opened.
While I was here I ended up renaming CodeAnalysisColors to DashboardColors which is a bit clearer what it is.