Skip to content

Use NativeIntegerMethodSymbol to represent parameter-less constructor. #56093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

Use NativeIntegerMethodSymbol to represent parameter-less constructor. #56093

merged 1 commit into from
Sep 2, 2021

Conversation

@AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Sep 1, 2021

Fixes #49845.

@AlekseyTs AlekseyTs requested a review from cston September 1, 2021 23:10
@AlekseyTs AlekseyTs requested a review from a team as a code owner September 1, 2021 23:10
jcouv
jcouv approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Sep 2, 2021
@AlekseyTs AlekseyTs merged commit a835dd8 into dotnet:main Sep 2, 2021
@ghost ghost added this to the Next milestone Sep 2, 2021
@Cosifne Cosifne modified the milestones: Next, 17.0.P5 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcouv jcouv jcouv approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jcouv jcouv

Labels

Area-Compilers

Projects

None yet

Milestone

17.0.P5

Development

Successfully merging this pull request may close these issues.

PEModuleBuilder.Translate(MethodSymbol, ...) doesn't translate constructor of a native int type, causing a crash in later on

4 participants

@AlekseyTs @cston @jcouv @Cosifne