Fix await completion provider to handle non-"true" local function declarations #56196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
davidwengier
reviewed
Sep 5, 2021
src/Features/CSharp/Portable/Completion/CompletionProviders/AwaitCompletionProvider.cs
Outdated
Show resolved
Hide resolved
…aitCompletionProvider.cs Co-authored-by: David Wengier <david.wengier@microsoft.com>
davidwengier
approved these changes
Sep 6, 2021
Member
|
Thanks @Youssef1313! At least someone is writing code on this US long weekend 😛 |
Contributor
|
This bug was already found as part of #55817. It was fixed in 5ff9d09. The fixes of @Youssef1313 and me are more or less identical. I merged main into that PR in c03b284 and removed the changes made here, but kept the test. |
jinujoseph
added
the
Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56006