Rework our netstandard1.3 test references #56223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `netstandard1.3` test references were being provided by our MS.CA.Test.Resources.Proprietary package. The contents of this package get included in the output directory of every single unit test DLL that we build (which contributes to build output size). The references themselves though were only used in a very small number of tests. This change upgrades to a version of MS.CA.Test.Resources.Proprietary that has the `netstandard1.3` references removed and adds the `netstandard1.3` references to only the projects that needs them
Member
Author
|
@dotnet/roslyn-compiler , @dotnet/roslyn-infrastructure PTAL |
jaredpar
commented
Sep 7, 2021
| } | ||
| #endif | ||
|
|
||
| private static ImmutableArray<byte> CreateCSharpAnalyzerNetStandard13(string analyzerAssemblyName) |
Member
Author
There was a problem hiding this comment.
note: this is not new code, I just moved it from the core test utilities project to here.
JoeRobich
approved these changes
Sep 7, 2021
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
netstandard1.3test references were being provided by ourMS.CA.Test.Resources.Proprietary package. The contents of this package
get included in the output directory of every single unit test DLL that
we build (which contributes to build output size). The references
themselves though were only used in a very small number of tests.
This change upgrades to a version of MS.CA.Test.Resources.Proprietary
that has the
netstandard1.3references removed and adds thenetstandard1.3references to only the projects that needs them