Skip to content

Merge main to main-vs-deps #56225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 7, 2021
Merged

Merge main to main-vs-deps #56225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c7a16e0
Remove the HasCompilation flag.
CyrusNajmabadi Sep 2, 2021
82a4adb
Don't try to rename references in source generated files
jasonmalinowski Sep 3, 2021
bf962c9
Fix await completion provider to handle non-"true" local function dec…
Youssef1313 Sep 6, 2021
4fada24
More options refactoring (#56089)
tmat Sep 7, 2021
409fcc2
Add External Access options for TypeScript (#56187)
tmat Sep 7, 2021
ec20540
Add readme.md listing breaking changes doc chronologically (#56019)
jcouv Sep 7, 2021
5851730
Provide real implementation for RuntimeSupportsStaticAbstractMembersI…
AlekseyTs Sep 7, 2021
7955a0a
Merge pull request #56132 from CyrusNajmabadi/removeHasCompilation
CyrusNajmabadi Sep 7, 2021
2fb8106
Merge pull request #56189 from jasonmalinowski/allow-rename-with-refe…
jasonmalinowski Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/compilers/CSharp/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Breaking changes (newest release on top):

- [.NET 6 and Visual Studio 2022](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20DotNet%206.md)
- [Minor releases following .NET 5 and Visual Studio 2019 version 16.9](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20post%20DotNet%205.md)
- [.NET 5 and Visual Studio 2019 version 16.9](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20DotNet%205.md)
- [Minor releases following Visual Studio 2019 version 16.0](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20post%20VS2019.md)
- [Visual Studio 2019 version 16.0](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20VS2019.md)
- [Minor releases following Visual Studio 2017 version 15.0](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20post%20VS2017.md)
- [Visual Studio 2017 version 15.0](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20VS2017.md)
- [Visual Studio 2015 version 14.0](https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20VS2015.md)
1 change: 1 addition & 0 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
<BasicUndoVersion>0.9.3</BasicUndoVersion>
<BasicReferenceAssembliesNetStandard20Version>1.2.1</BasicReferenceAssembliesNetStandard20Version>
<BasicReferenceAssembliesNet50Version>1.2.1</BasicReferenceAssembliesNet50Version>
<BasicReferenceAssembliesNet60Version>1.2.2</BasicReferenceAssembliesNet60Version>
<BenchmarkDotNetVersion>0.13.0</BenchmarkDotNetVersion>
<BenchmarkDotNetDiagnosticsWindowsVersion>0.13.0</BenchmarkDotNetDiagnosticsWindowsVersion>
<DiffPlexVersion>1.4.4</DiffPlexVersion>
Expand Down
3 changes: 1 addition & 2 deletions src/Compilers/CSharp/Portable/Symbols/AssemblySymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,8 +436,7 @@ internal bool RuntimeSupportsDefaultInterfaceImplementation
/// </summary>
internal bool RuntimeSupportsStaticAbstractMembersInInterfaces
{
// https://github.com/dotnet/roslyn/issues/53800: Implement the actual check, this is a temporary stub.
get => RuntimeSupportsDefaultInterfaceImplementation;
get => RuntimeSupportsFeature(SpecialMember.System_Runtime_CompilerServices_RuntimeFeature__VirtualStaticsInInterfaces);
}

private bool RuntimeSupportsFeature(SpecialMember feature)
Expand Down
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Test/Emit/Attributes/AttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10100,7 +10100,7 @@ public static void Main()
}
}
";
var comp = CreateCompilation(source, targetFramework: TargetFramework.NetCoreApp);
var comp = CreateCompilation(source, targetFramework: TargetFramework.Net60);
comp.VerifyEmitDiagnostics();
}

Expand Down
6 changes: 3 additions & 3 deletions src/Compilers/CSharp/Test/Symbol/Symbols/DefaultInterfaceImplementationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7003,7 +7003,7 @@ class Test2 : I1
";
var compilation1 = CreateCompilation(source1, options: TestOptions.DebugDll,
parseOptions: TestOptions.Regular9,
targetFramework: TargetFramework.NetCoreApp);
targetFramework: TargetFramework.Net60);

compilation1.VerifyDiagnostics(
// (10,24): error CS8703: The modifier 'sealed' is not valid for this item in C# 9.0. Please use language version 'preview' or greater.
Expand Down Expand Up @@ -12210,7 +12210,7 @@ class Test2 : I1
";
var compilation1 = CreateCompilation(source1, options: TestOptions.DebugDll,
parseOptions: TestOptions.Regular9,
targetFramework: TargetFramework.NetCoreApp);
targetFramework: TargetFramework.Net60);

compilation1.VerifyDiagnostics(
// (4,25): error CS8703: The modifier 'abstract' is not valid for this item in C# 9.0. Please use language version 'preview' or greater.
Expand Down Expand Up @@ -25379,7 +25379,7 @@ class Test2 : I1
";
var compilation1 = CreateCompilation(source1, options: TestOptions.DebugDll,
parseOptions: TestOptions.Regular9,
targetFramework: TargetFramework.NetCoreApp);
targetFramework: TargetFramework.Net60);

compilation1.VerifyDiagnostics(
// (8,46): error CS0073: An add or remove accessor must have a body
Expand Down
1 change: 1 addition & 0 deletions src/Compilers/CSharp/Test/Symbol/Symbols/MissingSpecialMember.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,7 @@ public void AllSpecialTypeMembers()
var symbol = comp.GetSpecialTypeMember(special);
if (special == SpecialMember.System_Runtime_CompilerServices_RuntimeFeature__DefaultImplementationsOfInterfaces
|| special == SpecialMember.System_Runtime_CompilerServices_RuntimeFeature__CovariantReturnsOfClasses
|| special == SpecialMember.System_Runtime_CompilerServices_RuntimeFeature__VirtualStaticsInInterfaces
|| special == SpecialMember.System_Runtime_CompilerServices_RuntimeFeature__UnmanagedSignatureCallingConvention
|| special == SpecialMember.System_Runtime_CompilerServices_PreserveBaseOverridesAttribute__ctor)
{
Expand Down
Loading