Add SolutionSessionId and ProjectsWithAppliedChanges telemetry properties #56947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tmat
changed the title
Member
Author
|
@davidwengier PTAL |
davidwengier
approved these changes
Oct 5, 2021
jinujoseph
added
Approved to merge
Needs Shiproom Approval
and removed
Approved to merge
labels
JoeRobich
reviewed
Oct 5, 2021
| { | ||
| private static readonly TestComposition s_composition = FeaturesTestCompositions.Features; | ||
| private static readonly Guid s_solutionTelemetryId = Guid.Parse("00000000-AAAA-AAAA-AAAA-000000000000"); | ||
| private static readonly Guid s_defaultProjectTelemetryId = Guid.Parse("00000000-AAAA-AAAA-AAAA-111111111111"); |
Member
There was a problem hiding this comment.
You could extract these strings out as constants and use them in the tests instead of inlining them.
Member
Author
There was a problem hiding this comment.
That would be too much clutter in the tests. These won't change and even if they did simple text replace would do. Also would make copy & paste of expected output from test output harder.
Contributor
|
cc @RikkiGibson fyi |
RikkiGibson
added a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to correlate EnC telemetry with properties of updated projects.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1415162
Contributes to https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1412234