Overload resolution was ignoring HasTypeArgumentInferredFromFunctionType for calls in expanded form #57633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
…ype for calls in expanded form
cston
commented
Nov 9, 2021
| new MemberResolutionResult<TMember>( | ||
| result.Member, | ||
| result.LeastOverriddenMember, | ||
| result.WithResult( |
Contributor
Author
AlekseyTs
reviewed
Nov 9, 2021
| if (typeArguments.IsDefault) | ||
| { | ||
| return new MemberResolutionResult<TMember>(member, leastOverriddenMember, inferenceError); | ||
| return new MemberResolutionResult<TMember>(member, leastOverriddenMember, inferenceError, hasTypeArgumentInferredFromFunctionType: false); |
Contributor
Contributor
Author
There was a problem hiding this comment.
We could although typeArguments.IsDefault is returned for error conditions, and hasTypeArgumentsInferredFromFunctionType == false.
333fred
approved these changes
Nov 9, 2021
cston
added a commit
to cston/roslyn
that referenced
this pull request
Nov 12, 2021
…ype for calls in expanded form (dotnet#57633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For calls to generic overloads with a
paramsparameter, overload resolution was ignoring whether type inference relied on function types, so the "better function member" was not preferring calls with no function types.Fixes #57627.