Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow xml docs to still be created when 'emit metadata only' is on. #57667

Merged
merged 17 commits into from
Jan 21, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/Compilers/CSharp/Test/Emit/Emit/CompilationEmitTests.cs
  • Loading branch information
CyrusNajmabadi authored Jan 20, 2022
commit 30493b143523bd2a89c0d0b8103d02bbcf1aee1f
Original file line number Diff line number Diff line change
@@ -485,7 +485,6 @@ public static void SayHello()
Assert.True(emitResult.Success);
emitResult.Diagnostics.Verify();

// Even though docs failed, we should still produce the peStream.
Assert.True(mdOnlyImage.Length > 0, "no metadata emitted");
Assert.Equal(
"<?xml version=\"1.0\"?>\r\n<doc>\r\n <assembly>\r\n <name>test</name>\r\n </assembly>\r\n <members>\r\n <member name=\"T:Goo.Bar.Test1\">\r\n <summary>This should emit</summary>\r\n </member>\r\n </members>\r\n</doc>\r\n",