Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SourceLink PRs #58109

Closed

Conversation

allisonchou
Copy link
Contributor

@allisonchou allisonchou commented Dec 3, 2021

Reverts #58051 and #57978 from the release/dev17.1-vs-deps branch due to regressions. (note, may not be reverted if regressions can be figured out before QB deadline.)

@ryzngard
Copy link
Contributor

ryzngard commented Dec 3, 2021

This is one of two options we're looking at. Other is #58108

@allisonchou
Copy link
Contributor Author

@davidwengier
Copy link
Contributor

Strictly speaking only #58051 needed to be reverted, but I wouldn't expect this to cause any trouble either.

@allisonchou
Copy link
Contributor Author

This should no longer be needed since #58108 merged in.

@allisonchou allisonchou closed this Dec 6, 2021
@allisonchou allisonchou deleted the RemovePRs branch December 6, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants