Skip to content

Conversation

@jcouv
Copy link
Member

@jcouv jcouv commented Dec 7, 2021

CC @cston

@jcouv jcouv self-assigned this Dec 7, 2021
@ghost ghost added the Area-Compilers label Dec 7, 2021
### Testing on the [dotnet/runtime](https://github.com/dotnet/runtime) repo

1. make sure that you can build the `runtime` repo as baseline (run `build.cmd libs`, which should be sufficient to build all C# code, installing any prerequisites if prompted to)
1. make sure that you can build the `runtime` repo as baseline (run `build.cmd clr+libs+libs.tests`, which should be sufficient to build all C# code, installing any prerequisites if prompted to. There's documentation on prerequisites on the runtime repo homepage. You may need to do `git clean -xdf` and `build.cmd -restore` before you can build successfully)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clr

build clr probably requires C++. Consider omitting clr, or mention that clr could be included if C++ is available.

### Testing on the [dotnet/runtime](https://github.com/dotnet/runtime) repo

1. make sure that you can build the `runtime` repo as baseline (run `build.cmd libs`, which should be sufficient to build all C# code, installing any prerequisites if prompted to)
1. make sure that you can build the `runtime` repo as baseline (run `build.cmd clr+libs+libs.tests`, which should be sufficient to build all C# code, installing any prerequisites if prompted to. There's documentation on prerequisites on the runtime repo homepage. You may need to do `git clean -xdf` and `build.cmd -restore` before you can build successfully)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. make sure that you can build the `runtime` repo as baseline (run `build.cmd clr+libs+libs.tests`, which should be sufficient to build all C# code, installing any prerequisites if prompted to. There's documentation on prerequisites on the runtime repo homepage. You may need to do `git clean -xdf` and `build.cmd -restore` before you can build successfully)
1. make sure that you can build the `runtime` repo as baseline (run `build.cmd libs+libs.tests`, which should be sufficient to build all C# code, installing any prerequisites if prompted to, and perhaps `git clean -xdf` and `build.cmd -restore` initially - see [runtime repo documentation](https://github.com/dotnet/runtime/blob/main/docs/workflow/README.md) for specific prerequisites and build instructions)

@jcouv jcouv requested a review from cston December 7, 2021 22:16
@jcouv jcouv merged commit c1f84ac into main Dec 12, 2021
@jcouv jcouv deleted the dev/jcouv/build-runtime branch December 12, 2021 20:03
@ghost ghost added this to the Next milestone Dec 12, 2021
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants