Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OmniSharp options - take 2 #58355

Merged
merged 2 commits into from
Dec 16, 2021
Merged

OmniSharp options - take 2 #58355

merged 2 commits into from
Dec 16, 2021

Conversation

tmat
Copy link
Member

@tmat tmat commented Dec 15, 2021 •
edited
Loading

Redo of #58208:

Further options refactoring focused on options set by OmniSharp.

Adds External Access APIs that allow OmniSharp to specify options directly.

Depends on VS insertion of https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/369132

@tmat tmat requested review from a team as code owners December 15, 2021 21:36
@ghost ghost added the Needs UX Triage label Dec 15, 2021
@tmat tmat changed the title Omni sharp options2 OmniSharp options - take 2 Dec 15, 2021
@tmat tmat mentioned this pull request Dec 15, 2021
Merged
2 tasks
@runfoapp runfoapp bot mentioned this pull request Dec 15, 2021
Closed
@tmat
Copy link
Member Author

tmat commented Dec 16, 2021

@JoeRobich

@dibarbet
Copy link
Member

dibarbet commented Dec 16, 2021 •
edited
Loading

@tmat does this require the TS change to be dual inserted, or just inserted before this one? just confirmed offline, just prior insertion

@tmat tmat merged commit 88f8299 into dotnet:main Dec 16, 2021
@ghost ghost added this to the Next milestone Dec 16, 2021
@tmat tmat deleted the OmniSharpOptions2 branch December 16, 2021 22:02
@tmat
Copy link
Member Author

tmat commented Dec 16, 2021 •
edited
Loading

TS bits inserted in https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/369975

@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-IDE UX Review Not Required UX Review Not Required
Projects
None yet
Milestone
17.1.P3
Development

Successfully merging this pull request may close these issues.
5 participants
@tmat @dibarbet @JoeRobich @ryzngard @Cosifne