Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required modifier parsing #58431

Merged
merged 5 commits into from
Jan 10, 2022
Merged

Required modifier parsing #58431

merged 5 commits into from
Jan 10, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented Dec 20, 2021

Implements parsing for required members.

Test plan: #57046
Spec: dotnet/csharplang#3630

@333fred
Required modifier parsing
d0cfb4b 
Implements parsing for required members.

Test plan: dotnet#57046
Spec: dotnet/csharplang#3630
@333fred 333fred requested a review from a team as a code owner December 20, 2021 20:00
@333fred 333fred requested review from jcouv and RikkiGibson December 20, 2021 20:01
@333fred
Copy link
Member Author

333fred commented Dec 20, 2021

@jcouv @RikkiGibson for review.

@333fred 333fred added the Feature - Required Members Required properties and fields label Dec 20, 2021
@runfoapp runfoapp bot mentioned this pull request Dec 20, 2021
Closed
@runfoapp runfoapp bot mentioned this pull request Dec 21, 2021
Closed
@333fred
Copy link
Member Author

333fred commented Jan 7, 2022

@jcouv @RikkiGibson for review.

jcouv
jcouv reviewed Jan 8, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 3)

@jcouv jcouv self-assigned this Jan 8, 2022
@RikkiGibson RikkiGibson self-assigned this Jan 10, 2022
RikkiGibson
RikkiGibson approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nits.

src/Compilers/CSharp/Test/Syntax/Parsing/MemberDeclarationParsingTests.cs Outdated Show resolved Hide resolved
src/Compilers/CSharp/Test/Syntax/Parsing/MemberDeclarationParsingTests.cs Show resolved Hide resolved
jcouv
jcouv approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@runfoapp runfoapp bot mentioned this pull request Jan 10, 2022
Closed
@333fred 333fred enabled auto-merge (squash) January 10, 2022 21:08
@333fred 333fred merged commit 8212481 into dotnet:features/required-members Jan 10, 2022
@333fred 333fred deleted the parsing branch January 10, 2022 22:51
@333fred 333fred mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@jcouv jcouv jcouv approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

@jcouv jcouv

Labels
Area-Compilers Feature - Required Members Required properties and fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@333fred @RikkiGibson @jcouv @Youssef1313