Remove BackgroundParser and BackgroundCompiler #58453
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Dec 22, 2021
| @@ -117,28 +114,12 @@ private static HostServices GetHostServices(ExportProvider? exportProvider = nul | |||
|
|
|||
| protected internal override bool PartialSemanticsEnabled | |||
| { | |||
| get { return _backgroundCompiler != null; } | |||
| get { return _partialSemanticsEnabled; } | |||
There was a problem hiding this comment.
Looks like this is always true?
Therzok
reviewed
Jan 5, 2022
| private readonly TaskQueue _taskQueue; | ||
|
|
||
| [SuppressMessage("CodeQuality", "IDE0052:Remove unread private members", Justification = "Used to keep a strong reference to the built compilations so they are not GC'd")] | ||
| private Compilation?[]? _mostRecentCompilations; |
There was a problem hiding this comment.
Isn't the purpose of this to have RecoverableValueSource compilation instances rooted here?
I'd imagine that without this code, the Compilation instances would likely be GC'd and recomputed constantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the proposal detailed in #58451