Handle /warnaserror with Warning analyzer bulk configuration in edito… #58460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rconfig Fixes batch compiler issue in dotnet#55541. I'll create a separate PR for the fix on IDE side
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Dec 22, 2021
…ation in editorconfig Underlying issue: dotnet#55541 Corresponding batch compiler fix: dotnet#58460 This change fixes the code that computes effective severity for Analyzers node. We also need to update the code that computes effective severity for EditorConfig UX, I will file a separate issue for the same. NOTE: We have dotnet#52720 to track avoiding code duplication for computing effective severity between EditorConfig UX and other parts of the IDE
This was referenced Dec 22, 2021
chsienki
approved these changes
Jan 11, 2022
|
Thanks Chris! @dotnet/roslyn-compiler for an additional review. |
cston
approved these changes
Jan 12, 2022
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rconfig
Fixes #55541