Remove a first chance exception for normal cancellation #58646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
genlu
reviewed
Jan 5, 2022
| public Task<bool> Delay(TimeSpan delay, CancellationToken cancellationToken) | ||
| { | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| if (cancellationToken.IsCancellationRequested) |
Member
There was a problem hiding this comment.
Could you please add some comments on why we'd go though the trouble to implement it this way?
Contributor
Author
There was a problem hiding this comment.
Added [PerformanceSensitive] with a text constraint.
genlu
approved these changes
Jan 5, 2022
This exception only occurs in integration test scenarios, but the internal performance test harness is not able to eliminate this false positive automatically.
Member
|
I have validated this in RPS. Delay no longer throws OCE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exception only occurs in integration test scenarios, but the internal performance test harness is not able to eliminate this false positive automatically.
This change negatively impacts maintainability of code with no end-user impact where functional correctness is critical, and should not be necessary.