Skip to content

Conversation

@cston
Copy link
Contributor

@cston cston commented Jan 10, 2022

Test plan: #54509

@cston cston requested a review from a team as a code owner January 10, 2022 23:26
@ghost ghost added the Area-Compilers label Jan 10, 2022
[Fact]
public void TestNormalizeLineSpanDirectiveTrivia()
{
TestNormalizeTrivia(" # line(1,2)-(3,4)5\"a.txt\"", "#line (1, 2) - (3, 4) 5 \"a.txt\"\r\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider putting incorrect spaces in around the numbers in the input value: line( 1 ,2 )...

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jan 11, 2022
@cston cston merged commit 7ee9280 into dotnet:main Jan 11, 2022
@ghost ghost added this to the Next milestone Jan 11, 2022
@cston cston deleted the line-span-tests branch January 11, 2022 19:53
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants