Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove formatting suppression for tuple syntax #58810

Merged
merged 7 commits into from
Jan 14, 2022
Merged

Remove formatting suppression for tuple syntax #58810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a6854f
Close 56498
jcouv Jan 10, 2022
3e74921
Update dotnet-format version to match CodeStyle version
jcouv Jan 11, 2022
98f1b54
typo
jcouv Jan 11, 2022
4613d4b
Use 4.0.1
jcouv Jan 12, 2022
f1cea8d
Use 6.0.257007
jcouv Jan 12, 2022
884116c
Add argument to dotnet-format
jcouv Jan 13, 2022
9c84b0a
Use whitespace command
jcouv Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"isRoot": true,
"tools": {
"dotnet-format": {
"version": "6.0.240501",
"version": "6.0.257007",
"commands": [
"dotnet-format"
]
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<MicrosoftCodeAnalysisTestingVersion>1.1.1-beta1.21480.3</MicrosoftCodeAnalysisTestingVersion>
<MicrosoftVisualStudioExtensibilityTestingVersion>0.1.122-beta</MicrosoftVisualStudioExtensibilityTestingVersion>
<!-- CodeStyleAnalyzerVersion should we updated together with version of dotnet-format in dotnet-tools.json -->
<CodeStyleAnalyzerVersion>4.0.0-3.final</CodeStyleAnalyzerVersion>
<CodeStyleAnalyzerVersion>4.0.1</CodeStyleAnalyzerVersion>
<VisualStudioEditorPackagesVersion>16.10.230</VisualStudioEditorPackagesVersion>
<VisualStudioEditorNewPackagesVersion>17.0.487</VisualStudioEditorNewPackagesVersion>
<ILAsmPackageVersion>5.0.0-alpha1.19409.1</ILAsmPackageVersion>
Expand Down
2 changes: 1 addition & 1 deletion eng/test-build-correctness.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ try {
# Verify the state of our generated syntax files
Write-Host "Checking generated compiler files"
Exec-Block { & (Join-Path $PSScriptRoot "generate-compiler-code.ps1") -test -configuration:$configuration }
Exec-Console dotnet "tool run dotnet-format . --include-generated --include src/Compilers/CSharp/Portable/Generated/ src/Compilers/VisualBasic/Portable/Generated/ src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/Generated/ --check -f"
Exec-Console dotnet "tool run dotnet-format whitespace . --folder --include-generated --include src/Compilers/CSharp/Portable/Generated/ src/Compilers/VisualBasic/Portable/Generated/ src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/Generated/ --verify-no-changes"
Write-Host ""

exit 0
Expand Down
2 changes: 0 additions & 2 deletions src/Compilers/CSharp/Portable/Binder/EarlyWellKnownAttributeBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,11 @@ internal EarlyWellKnownAttributeBinder(Binder enclosing)
// Hide the GetAttribute overload which takes a diagnostic bag.
// This ensures that diagnostics from the early bound attributes are never preserved.
[Obsolete("EarlyWellKnownAttributeBinder has a better overload - GetAttribute(AttributeSyntax, NamedTypeSymbol, out bool)", true)]
#pragma warning disable format // https://github.com/dotnet/roslyn/issues/56498
internal new (CSharpAttributeData, BoundAttribute) GetAttribute(
AttributeSyntax node, NamedTypeSymbol boundAttributeType,
Action<AttributeSyntax> beforeAttributePartBound,
Action<AttributeSyntax> afterAttributePartBound,
BindingDiagnosticBag diagnostics)
#pragma warning restore format
{
Debug.Assert(false, "Don't call this overload.");
diagnostics.Add(ErrorCode.ERR_InternalError, node.Location);
Expand Down