Reduce Stack Trace Explorer automatic open behavior scope

src/Features/Core/Portable/StackTraceExplorer/IgnoredFrame.cs

@@ -13,8 +13,6 @@ public IgnoredFrame(string originalText)
  _originalText = originalText;
  }
 
- public override bool IsStackFrame => false;
-
  public override string ToString()
  {
  return _originalText;

src/Features/Core/Portable/StackTraceExplorer/ParsedFrame.cs

@@ -9,7 +9,5 @@ internal abstract class ParsedFrame
  public ParsedFrame()
  {
  }
-
- public abstract bool IsStackFrame { get; }
  }
 }

src/Features/Core/Portable/StackTraceExplorer/ParsedStackFrame.cs

@@ -32,8 +32,6 @@ public ParsedStackFrame(
 
  public StackFrameCompilationUnit Root => Tree.Root;
 
- public override bool IsStackFrame => true;
-
  public override string ToString()
  {
  return Tree.Text.CreateString();

src/VisualStudio/Core/Def/StackTraceExplorer/StackTraceExplorerCommandHandler.cs

@@ -6,6 +6,7 @@
 using System.ComponentModel.Design;
 using System.IO.Packaging;
 using Microsoft.CodeAnalysis.Editor.Shared.Utilities;
+using Microsoft.CodeAnalysis.Internal.Log;
 using Microsoft.CodeAnalysis.Options;
 using Microsoft.CodeAnalysis.StackTraceExplorer;
 using Microsoft.VisualStudio.LanguageServices.Setup;
@@ -63,6 +64,7 @@ public int OnBroadcastMessage(uint msg, IntPtr wParam, IntPtr lParam)
  await _threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync();
  var windowFrame = (IVsWindowFrame)window.Frame;
  ErrorHandler.ThrowOnFailure(windowFrame.Show());
+ Logger.Log(FunctionId.StackTraceToolWindow_ShowOnActivated, logLevel: LogLevel.Information);
  }
  });
 

src/VisualStudio/Core/Def/StackTraceExplorer/StackTraceExplorerToolWindow.cs

@@ -12,6 +12,7 @@
 using System.Windows.Controls;
 using System.Windows.Input;
 using Microsoft.CodeAnalysis.Editor.Shared.Utilities;
+using Microsoft.CodeAnalysis.EmbeddedLanguages.StackFrame;
 using Microsoft.CodeAnalysis.StackTraceExplorer;
 using Microsoft.VisualStudio.Imaging;
 using Microsoft.VisualStudio.LanguageServices.Setup;
@@ -72,7 +73,7 @@ public async Task<bool> ShouldShowOnActivatedAsync(CancellationToken cancellatio
  }
 
  var result = await StackTraceAnalyzer.AnalyzeAsync(text, cancellationToken).ConfigureAwait(false);
- if (result.ParsedFrames.Any(static frame => frame.IsStackFrame))
+ if (result.ParsedFrames.Any(static frame => FrameTriggersActivate(frame)))
  {
  await Root.ViewModel.AddNewTabAsync(result, text, cancellationToken).ConfigureAwait(false);
  return true;
@@ -81,6 +82,35 @@ public async Task<bool> ShouldShowOnActivatedAsync(CancellationToken cancellatio
  return false;
  }
 
+ private static bool FrameTriggersActivate(ParsedFrame frame)
+ {
+ if (frame is not ParsedStackFrame parsedFrame)
+ {
+ return false;
+ }
+
+ var methodDeclaration = parsedFrame.Root.MethodDeclaration;
+
+ // Find the first token
+ var firstNodeOrToken = methodDeclaration.ChildAt(0);
+ while (firstNodeOrToken.IsNode)
+ {
+ firstNodeOrToken = firstNodeOrToken.Node.ChildAt(0);
+ }
+
+ if (firstNodeOrToken.Token.LeadingTrivia.IsDefault)
+ {
+ return false;
+ }
+
+ // If the stack frame starts with "at" we consider it a well formed stack frame and 
+ // want to automatically open the window. This helps avoids some false positive cases 
+ // where the window shows on code that parses as a stack frame but may not be. The explorer
+ // should still handle those cases if explicitly pasted in, but can lead to false positives 
+ // when automatically opening.
+ return firstNodeOrToken.Token.LeadingTrivia.Any(t => t.Kind == StackFrameKind.AtTrivia);
+ }
+
  public void InitializeIfNeeded(RoslynPackage roslynPackage)
  {
  if (_initialized)

src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Log/FunctionId.cs

@@ -537,5 +537,7 @@ internal enum FunctionId
 
  Inline_Hints_DoubleClick = 530,
  NavigateToExternalSources = 531,
+
+ StackTraceToolWindow_ShowOnActivated = 540,
  }
 }