Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EnC] Store entire spans instead of line deltas #58831

Merged
merged 4 commits into from
Jan 21, 2022
Merged

[EnC] Store entire spans instead of line deltas #58831

merged 4 commits into from
Jan 21, 2022

Commits on Jan 13, 2022

  1. Change LineDelta to NewSpan 

    Storing the entire span instead of calculating the line delta gives more accurate results where more than just line delta is needed.
We instead now calculate the line delta when we need to provide it to the debugger.
    @davidwengier
    davidwengier committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    a095596 View commit details
    Browse the repository at this point in the history

  2. Update tests 

    Responding to the rename, and the change in debugger display, used for test verification.
    @davidwengier
    davidwengier committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    296c592 View commit details
    Browse the repository at this point in the history

  3. Add new test to validate new spans are stored correctly

    @davidwengier
    davidwengier committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    6103bfe View commit details
    Browse the repository at this point in the history

  4. Rneame Span to OldSpan. 

    Just cleaning things up
    @davidwengier
    davidwengier committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7430a7c View commit details
    Browse the repository at this point in the history