draft: dummy change to see what's affected by this code path #58833
Conversation
ghost
added
the
Community
| @@ -576,7 +576,7 @@ protected void VisitLvalue(BoundExpression node) | |||
| var backingField = (access.PropertySymbol as SourcePropertySymbolBase)?.BackingField; | |||
| if (backingField != null) | |||
| { | |||
| VisitFieldAccessInternal(access.ReceiverOpt, backingField); | |||
| //VisitFieldAccessInternal(access.ReceiverOpt, backingField); | |||
There was a problem hiding this comment.
It's really very weird that CI is still passing with this change.
@AlekseyTs Is this, somehow, a dead code? Or is test coverage not enough?
I'm not able to see what we need to do around the Binder.AccessingAutoPropertyFromConstructor for this code path if I don't know what it currently affects. Can you help please?
There was a problem hiding this comment.
I'm not able to see what we need to do around the
Binder.AccessingAutoPropertyFromConstructorfor this code path if I don't know what it currently affects. Can you help please?
I think the better way to see what Binder.AccessingAutoPropertyFromConstructor affects is to pretend that it never returns true on this code path and see what happens then. It is quite possible that not calling VisitFieldAccessInternal is pretty much unobservable, but the change doesn't test what we would do instead if Binder.AccessingAutoPropertyFromConstructor return false.
My theory is that here we are trying to analyze a property assignment as a backing field assignment when we are certain that that is what the assignment would ultimately do.
(For continuing #58832 later)
Running
Build.cmd -testCoreClrdidn't report any relevant test failures. So letting CI tell me.