Steps to investigate CI flakiness with async-streams tests #58864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
commented
Jan 14, 2022
| public ValueTaskSourceStatus GetStatus(short token) | ||
| { | ||
| ValidateToken(token); | ||
| return | ||
| !_completed ? ValueTaskSourceStatus.Pending : | ||
| _continuation == null || !_completed ? ValueTaskSourceStatus.Pending : |
There was a problem hiding this comment.
@stephentoub FWIW, this seems the only actual code change when updating ManualResetValueTaskSourceCore source code, but I'm not seeing how it could relate to the symptom (ie. the completion sentinel being invoked, see stacktrace below).
Although almost all the failures occur on Linux, there's one on Windows too (so not exclusive).
at System.Threading.Tasks.Sources.ManualResetValueTaskSourceCoreShared.ThrowInvalidOperationException()
at System.Threading.Tasks.Sources.ManualResetValueTaskSourceCoreShared.CompletionSentinel(Object _)
at System.Threading.Tasks.Sources.ManualResetValueTaskSourceCore`1.InvokeContinuation()
at System.Threading.Tasks.Sources.ManualResetValueTaskSourceCore`1.SignalCompletion()
at System.Threading.Tasks.Sources.ManualResetValueTaskSourceCore`1.SetResult(TResult result)
at C.<Main>g__local|0_0()
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at System.Runtime.CompilerServices.AsyncIteratorMethodBuilder.MoveNext[TStateMachine](TStateMachine& stateMachine)
at C.<Main>g__local|0_0()
at C.Main()
at C.Main()
at C.<Main>()
There was a problem hiding this comment.
That change came from dotnet/coreclr#22711 which was addressing a race condition. So... it might be relevant.
|
Merging with a single review since test-only change. Thanks |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion with Stephen, those steps should help:
Relates to #34207
Relates to #58196
Relates to #47156
Relates to #40927