Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone source from mirror for DartLab integration tests #58872

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jan 14, 2022

There were concern about automatically running this pipeline and building from GitHub. I have updated the pipeline to pull source from our internal mirror instead.

Test run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5632203&view=results (microsoft)

@@ -54,6 +62,7 @@ stages:
filePath: $(DartLab.Path)\Scripts\VisualStudio\Build\Get-VisualStudioDropName.ps1
arguments: -DropNamePrefix 'Products' -VstsDropUrlsJson '$(Pipeline.Workspace)\VisualStudioBuildUnderTest\BuildArtifacts\VstsDropUrls.json' -OutVariableName 'VisualStudio.BuildUnderTest.ProductsDropName'
deployAndRunTestsStepList:
- checkout: RoslynMirror
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we do not specify - checkout: self we are pulling the source from our mirror instead of GH.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this run the full git checkout or the modified one that we built which does a minimal checkout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AzDO running its full git checkout. I will have to see how extra git resources are managed to determine if we can update our checkout task.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's anything that should block this change but is something that we should keep an eye on. The frequency of our checkouts in normal CI made this a problem, doubt this hits as frequently hence less of a trigger point.

@JoeRobich
Copy link
Member Author

@jaredpar Please take a look

Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to use the checkout task (modify to parameterize what repo we use?) but not important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants