Defer part rejection exception in VSTypeScriptFormattingService to time of construction #58940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Jan 19, 2022
...ore/Portable/ExternalAccess/VSTypeScript/Api/IVSTypeScriptFormattingServiceImplementation.cs
Outdated
Show resolved
Hide resolved
src/CodeStyle/Core/CodeFixes/Host/Mef/CodeStyleHostLanguageServices.cs.cs
Show resolved
Hide resolved
2 tasks
|
@jasonmalinowski Based on the comments from @zkat , I plan to keep this pull request in its current form and marking it as auto-merge. |
jasonmalinowski
requested changes
Jan 20, 2022
...ore/Portable/ExternalAccess/VSTypeScript/Api/IVSTypeScriptFormattingServiceImplementation.cs
Outdated
Show resolved
Hide resolved
…quire it in the constructor This change defers the MEF part creation exception in MEF 2 scenarios from the call to GetExports to the call (if any) to Lazy<>.Value. Rather than reject the part from the catalog entirely, this change allows the part to be included as long as it is not accessed.
sharwell
changed the title
jasonmalinowski
approved these changes
Jan 21, 2022
Comment on lines
+25
to
+26
| public VSTypeScriptFormattingService([Import(AllowDefault = true)] IVSTypeScriptFormattingServiceImplementation impl) | ||
| => _impl = impl ?? throw new ArgumentNullException(nameof(impl)); |
There was a problem hiding this comment.
This probably deserves a comment here explaining why we are doing AllowDefault but then still blocking it. Feel free to add as a follow-up since CI is green.
ghost
added this to the 
|
https://sharplab.io seems to fail even after this merge, see.: ashmind/SharpLab#922 |
|
@bernd5 That issue was filed before this change was merged. Do you have information about the failure which still occurs? |
|
@sharwell: Oh, I have mixed up a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58817 (comment)