Retry opening LightBulb when the session is canceled

[JoeRobich]

Resolves #57722

[ryzngard]

When the session is canceled instead of completed we throw an InvalidOperationException

This makes me sad :( It should be a cancellation exception right?

[CyrusNajmabadi]

who is 'we' here?

[CyrusNajmabadi]

hrmm. i see:

                if (DateTimeOffset.Now > startTime + Helper.HangMitigatingTimeout)
                {
                    throw new InvalidOperationException("Expected a light bulb session to appear.");
                }

But this seems appropriate. if we invoked the lightbulb... and it didn't appear. then we have a product bug. retrying it legit seems to be maskign things.

[CyrusNajmabadi]

this seems to mask a real product failure.

[sharwell]

Reviewing relative to substantial changes already made in the new integration tests

[sharwell]

this seems to mask a real product failure.

It is a real product failure, but outside our control. We can't just leave all code action integration tests disabled for months waiting for a public release with a fix.

[sharwell]

This change should use the following approach:

roslyn/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorInProcess.cs

Lines 356 to 374 in 1138ef8

	public async Task InvokeCodeActionListAsync(CancellationToken cancellationToken)
	{
	await TestServices.Workspace.WaitForAsyncOperationsAsync(FeatureAttribute.SolutionCrawler, cancellationToken);
	await TestServices.Workspace.WaitForAsyncOperationsAsync(FeatureAttribute.DiagnosticService, cancellationToken);
	if (Version.Parse("17.1.31916.450") > await TestServices.Shell.GetVersionAsync(cancellationToken))
	{
	// Workaround for extremely unstable async lightbulb prior to:
	// https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform/pullrequest/361759
	await TestServices.Input.SendAsync(new KeyPress(VirtualKey.Period, ShiftState.Ctrl));
	await Task.Delay(5000, cancellationToken);
	await TestServices.Editor.DismissLightBulbSessionAsync(cancellationToken);
	await Task.Delay(5000, cancellationToken);
	}
	await ShowLightBulbAsync(cancellationToken);
	await TestServices.Workspace.WaitForAsyncOperationsAsync(FeatureAttribute.LightBulb, cancellationToken);
	}

[CyrusNajmabadi]

It is a real product failure, but outside our control.

That's fair. Do we have a tracking bug for the real failure? we can then undo this once that goes in.

[sharwell]

Do we have a tracking bug for the real failure?

Already fixed (internal PR linked in code in my reply)

[JoeRobich]

superseded by #59457