Go To Implementation show metadata results

[davidwengier]

Part of #58147

Looks like this:

[davidwengier]

Still investigating the integration test failures, unfortunately I can't seem to run them at all locally.

[davidwengier]

@sharwell any pro tips for investigating the integration test failures? From the logs the exceptions seem to come from inside DTE, and whilst the failures are oddly related to what i'm working on (Find Refs vs Go To Impl) I don't believe any of the code I've changed could be at fault here.

Most frustratingly I can't seem to run any integration tests locally at the moment, but manually executing things the scenarios certainly work.

The error:

 Failed Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpFindReferences.FindReferencesToLocals (VS2022) [2 s]
  Error Message:
   System.ArgumentException : index
  Stack Trace:
     at Microsoft.VisualStudio.Platform.WindowManagement.DTE.WindowsCollection.Item(Object index)
   at Microsoft.VisualStudio.Shell.ThreadHelper.Invoke[TResult](Func`1 method)
   at EnvDTE80.ToolWindows.GetToolWindow(String Name)
   at Roslyn.VisualStudio.IntegrationTests.InProcess.FindReferencesWindowInProcess.<GetFindReferencesWindowAsync>d__1.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/FindReferencesWindowInProcess.cs:line 62
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Roslyn.VisualStudio.IntegrationTests.InProcess.FindReferencesWindowInProcess.<GetContentsAsync>d__0.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/FindReferencesWindowInProcess.cs:line 28
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpFindReferences.<FindReferencesToLocals>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpFindReferences.cs:line 105
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpFindReferences.<FindReferencesToLocals>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpFindReferences.cs:line 128
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

[CyrusNajmabadi]

note: we likely want to move this to be entirely streaming so that we're not blockign the find-impls results on doign all the search and conversion here of all these types.

[CyrusNajmabadi]

tentative approval, pending:

1. confirmation that the stock-vs experience with go-to-impl still shows source results first.
2. some clarity on the current shape.

[davidwengier]

1. confirmation that the stock-vs experience with go-to-impl still shows source results first.

When I run devenv /ResetSettings /RootSuffix NewHiveForCyrus I see only source results, and have to switch to one of the other filters to get external sources to show. I cannot 100% rule out that isn't because of a saved setting somewhere, as the filter does remember (which also means, if this does regress the experience, its one click and it never will again). I signed out of VS and same result, so synced settings definitely aren't an issue.

From my understanding and experimentation however, nothing overrides user sorting/grouping/filtering in order to show source results first. It's certainly something I can raise with the editor team, but my preference would not be to block this PR on it, mainly because I'd rather get you, and everyone else, dogfooding it and see if people have usability issues, and we can always revert the PR.

The issue is that it's trivial to issue a Go To Implementation command on IDisposable.DIspose() and show how problematic this can be, but I feel like thats looking for a problem. I'd rather wait and see if users natural GoToImpl scenarios are adversely affected by this change.

[davidwengier]

@sharwell you probably want to take a look at this, I had to make a bunch of integration test changes.

Turns out that the presence of additional filters in the Find References window changes the window caption. Personally I prefer the Guid approach anyway, window caption feels more vulnerable to flakiness.