Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Microsoft.CodeAnalysis.Collections.Package on net6.0 #59187

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Feb 1, 2022

Follow-up to #57665

@sharwell

This comment was marked as resolved.

@jaredpar
Copy link
Member

jaredpar commented Feb 1, 2022

@sharwell you need to update the exclusions to include the new TF. Example is here

27e5492

These exclusions exist because the .csproj files for our source NuPkg use the following

    <DebugType>none</DebugType>

The rebuild leg requires a PDB (embedded or on disk) in order to execute the rebuild logic. Lacking a PDB the DLLs must be excluded from our rebuild work.

Ideally we'd just change this to have a PDB. It's unclear to me why it's explicitly turned off here.

@sharwell sharwell marked this pull request as ready for review February 3, 2022 15:43
@sharwell sharwell requested a review from a team as a code owner February 3, 2022 15:43
@sharwell sharwell merged commit 3d22f0b into dotnet:main Feb 7, 2022
@sharwell sharwell deleted the validate-net6 branch February 7, 2022 04:38
@ghost ghost added this to the Next milestone Feb 7, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants