Revert "Remove dependency on EditorFeatures from Remote.ServiceHub project - take 2" #59242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmat, I must apologize for the inconvenience here, but I didn't get enough runway here to coordinate an insertion with TypeScript. I need to merge this revert for now. We can revisit in 17.2-preview2. Changes which require dual insertions need to be coordinated closely with infraswat, at minimum by tagging @dotnet/roslyn-infrastructure on GitHub or ideally by identifying the current tiger--you can always ask in the InfraSwat Teams channel. and messaging them in advance. |
|
@RikkiGibson My bad, I probably accidentally hit "automerge". As stated in the description this needs to wait for Type Script. |
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Feb 5, 2022
…ceHub project - take 2 (dotnet#59147)" (dotnet#59242)" This reverts commit 8d81aa5.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Feb 7, 2022
…ceHub project - take 2 (dotnet#59147)" (dotnet#59242)" This reverts commit 8d81aa5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #59147
Validation: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/377713