Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove-using when surrounded by pp directives in empty files #59282

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Fix remove-using when surrounded by pp directives in empty files #59282

merged 2 commits into from
Feb 4, 2022

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #1323

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner February 4, 2022 18:28
sharwell
sharwell approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these tests failed prior to the fix?

@CyrusNajmabadi
Copy link
Member Author

I'm assuming these tests failed prior to the fix?

yes.

@CyrusNajmabadi CyrusNajmabadi merged commit b6e8cae into dotnet:main Feb 4, 2022
@ghost ghost added this to the Next milestone Feb 4, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the removeUsingsPPDirective branch February 4, 2022 20:35
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.

Incorrect behavior around directives for unused usings code fix when file only contains usings
4 participants
@CyrusNajmabadi @ryzngard @sharwell @RikkiGibson