Finalize New Inline Rename UI #59351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
force-pushed
the
features/rename_ui_work/new_ui
branch
3 times, most recently
from
23afe4e to
f663b6f
Compare
|
Boy that really is very collapsed... (you forgot to paste in the image) |
davidwengier
approved these changes
Feb 8, 2022
Currently fighting build errors locally and couldn't run it again :( collapsed state is more a testament of myself than the adornment. |
ryzngard
force-pushed
the
features/rename_ui_work/new_ui
branch
from
55286eb to
3124503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final spec for the rename UI. Shown are the two states: collapsed and expanded.
Expanded