Support parsing of checked user-defined operator declarations #59504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3305,8 +3305,23 @@ private ConversionOperatorDeclarationSyntax TryParseConversionOperatorDeclaratio | |||
|
|
|||
| if (style.IsMissing) | |||
| { | |||
| if (this.CurrentToken.Kind != SyntaxKind.OperatorKeyword || SyntaxFacts.IsAnyOverloadableOperator(this.PeekToken(1).Kind) || | |||
| bool possibleConversion = true; | |||
There was a problem hiding this comment.
nit: remove initial value. it is never observed. #Resolved
|
NIt: consider detecting, reporting, and gracefully recovering from errant use of |
CyrusNajmabadi
approved these changes
Feb 12, 2022
Youssef1313
reviewed
Feb 12, 2022
| @@ -2514,6 +2514,33 @@ public static BlockSyntax Block(IEnumerable<StatementSyntax> statements) | |||
| expressionBody: expressionBody); | |||
| } | |||
|
|
|||
| /// <summary>Creates a new ConversionOperatorDeclarationSyntax instance.</summary> | |||
There was a problem hiding this comment.
nit: <see cref="..." /> (applies to below methods as well) #Resolved
|
@dotnet/roslyn-compiler Please review |
|
@333fred, @dotnet/roslyn-compiler For the second review. |
jcouv
approved these changes
Feb 15, 2022
|
azp /run |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/csharplang/blob/main/proposals/checked-user-defined-operators.md
Language version checks and whether
checkedis applicable to specific operator will be checked during declaration binding and is out of scope for this PR.Relates to test plan #59458