IDE0056, IDE0057: Move language version check to compilation start, minor cleanup #59523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Community
Youssef1313
commented
Feb 13, 2022
| protected override void InitializeWorker(AnalysisContext context) | ||
| { | ||
| context.RegisterCompilationStartAction(startContext => | ||
| context.RegisterCompilationStartAction(context => |
Member
Author
There was a problem hiding this comment.
Below callbacks were originally registered using the AnalysisContext rather than the CompilationStartAnalysisContext
I'm not sure if this makes any different, but we should be using the most-nested context anyway, so shadowing is very intended.
CyrusNajmabadi
approved these changes
Feb 13, 2022
Member
|
Thanks! |
1 similar comment
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59514 (the issue itself was already fixed and tested - I'm only addressing #59514 (comment))