Fix flaky test #59632
Merged
Fix flaky test #59632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was trying to assert that we didn't do a reparse by comparing the green nodes of the two trees. We didn't hold onto the root of the old tree, so it was possible for the root to fall away if we were testing recoverable trees. If the root had fallen away, it meant that asking for the old root would recover it as well, which would result in deserializing the roots twice and the green nodes being different. The fix is to ensure the root doesn't fall away.
jasonmalinowski
force-pushed
the
fix-flaky-test
branch
from
08cc97f to
46b782f
Compare
Cosifne
approved these changes
Feb 18, 2022
JoeRobich
approved these changes
Feb 18, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was trying to assert that we didn't do a reparse by comparing the green nodes of the two trees. We didn't hold onto the root of the old tree, so it was possible for the root to fall away if we were testing recoverable trees. If the root had fallen away, it meant that asking for the old root would recover it as well, which would result in deserializing the roots twice and the green nodes being different.
The fix is to ensure the root doesn't fall away.