Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatter and smart indentation tests for checked operators #60375

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Add formatter and smart indentation tests for checked operators #60375

merged 3 commits into from
Mar 25, 2022

Conversation

dibarbet
Copy link
Member

also added a couple for user defined operators since those didn't exist either

@dibarbet dibarbet marked this pull request as ready for review March 25, 2022 01:05
@dibarbet dibarbet requested a review from a team as a code owner March 25, 2022 01:05
@dibarbet dibarbet requested a review from CyrusNajmabadi March 25, 2022 01:05
@dibarbet dibarbet added the LSP issues related to the roslyn language server protocol implementation label Mar 25, 2022
@dibarbet dibarbet requested a review from AlekseyTs March 25, 2022 01:05
AlekseyTs
AlekseyTs approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

This was referenced Mar 25, 2022
Closed
Closed
Closed
CyrusNajmabadi
CyrusNajmabadi reviewed Mar 25, 2022
View reviewed changes
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/FormattingRangeHelper.cs
@@ -125,7 +125,8 @@ MethodDeclarationSyntax or
PropertyDeclarationSyntax or
ConstructorDeclarationSyntax or
DestructorDeclarationSyntax or
OperatorDeclarationSyntax)
OperatorDeclarationSyntax or
ConversionOperatorDeclarationSyntax)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aamzing.

@dibarbet dibarbet enabled auto-merge (squash) March 25, 2022 18:38
@dibarbet dibarbet mentioned this pull request Mar 25, 2022
Closed
78 tasks
@dibarbet dibarbet merged commit 3979e18 into dotnet:features/CheckedUserDefinedOperators Mar 25, 2022
@dibarbet dibarbet deleted the formatting_indentation_tests branch March 25, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-IDE Feature - CheckedUserDefinedOperators LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dibarbet @davidwengier @CyrusNajmabadi @AlekseyTs