Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cases where 'field' keyword shouldn't generate a field #60806

Merged
merged 7 commits into from
Apr 28, 2022
Merged

Handle cases where 'field' keyword shouldn't generate a field #60806

merged 7 commits into from
Apr 28, 2022

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 requested a review from a team as a code owner April 17, 2022 14:46
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 17, 2022
@Youssef1313
Copy link
Member Author

I'm not sure if the tests timeout is related to my changes. Can someone restart to see if they still fail?

@Youssef1313
Copy link
Member Author

@AlekseyTs CI is green here. This is ready for review.

AlekseyTs
AlekseyTs previously approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (commit 2)

@Youssef1313 Youssef1313 requested a review from AlekseyTs April 22, 2022 09:48
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 4).

@Youssef1313 Youssef1313 requested a review from AlekseyTs April 23, 2022 16:35
@AlekseyTs AlekseyTs dismissed their stale review April 28, 2022 17:34

Approved by mistake?

@AlekseyTs
Copy link
Contributor 

internal class FieldKeywordBinder : Binder

It doesn't look like there are any meaningful changes in this file. Please revert/exclude from the PR.

Refers to: src/Compilers/CSharp/Portable/Binder/FieldKeywordBinder.cs:12 in 6840e22. [](commit_id = 6840e22, deletion_comment = False)

@AlekseyTs
Copy link
Contributor 

internal class SpeculativeFieldKeywordBinder : Binder

It doesn't look like there are any meaningful changes in this file. Please revert/exclude from the PR.

Refers to: src/Compilers/CSharp/Portable/Binder/SpeculativeFieldKeywordBinder.cs:12 in 6840e22. [](commit_id = 6840e22, deletion_comment = False)

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 5). Other than a couple of files without meaningful changes, LGTM.

@AlekseyTs AlekseyTs requested review from 333fred and a team April 28, 2022 17:43
@AlekseyTs
Copy link
Contributor

@333fred, @dotnet/roslyn-compiler Need a second review on a small community PR.

@333fred 333fred self-assigned this Apr 28, 2022
333fred
333fred approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 5)

@333fred 333fred enabled auto-merge (squash) April 28, 2022 18:49
@333fred 333fred merged commit 1bcdda0 into dotnet:features/semi-auto-props Apr 28, 2022
@Youssef1313 Youssef1313 deleted the cannot-have-field branch April 28, 2022 19:55
AlekseyTs
AlekseyTs reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs left review comments

@333fred 333fred 333fred approved these changes

Assignees

@333fred 333fred

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @AlekseyTs @333fred