Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct directory for loghub logs #61104

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented May 3, 2022

LSP logs moved to loghub so integration tests need to look at the correct location

@dibarbet dibarbet marked this pull request as ready for review May 3, 2022 17:25
@dibarbet dibarbet requested a review from a team as a code owner May 3, 2022 17:25
@dibarbet
Copy link
Member Author

dibarbet commented May 3, 2022

verified logs are present

@dibarbet dibarbet enabled auto-merge (squash) May 3, 2022 17:25
@dibarbet dibarbet merged commit 22207e4 into main May 3, 2022
@ghost ghost added this to the Next milestone May 3, 2022
@dibarbet dibarbet deleted the dev/dibarbet/lsp_test_logs branch May 3, 2022 20:22
333fred added a commit that referenced this pull request May 4, 2022
…ures/required-members

* upstream/main: (368 commits)
  Use new helpers
  Cleanup
  Update src/EditorFeatures/CSharpTest/StringCopyPaste/StringCopyPasteCommandHandlerTests.cs
  Restore
  Add docs
  Fix
  Update Tools|Options code ordering to match waht is in the UI
  Use correct directory for loghub logs (#61104)
  Move usings on paste off the UI thread (#61092)
  Create shared helper to handle finding extensions in analyzer references
  Code style to convert byte arrays to UTF8 strings (#60647)
  Fixup
  Enable semantic token LSP tests + re-enable quick info tests (#61098)
  Simplify initialization logic
  Simplify common CWT pattern
  Simplify common CWT pattern
  Simplify common CWT pattern
  Simplify common CWT pattern
  Simplify common CWT pattern
  Simplify common CWT pattern
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request May 13, 2022
…o poison

* upstream/features/required-members: (369 commits)
  Update tests after merge
  Use new helpers
  Cleanup
  Update src/EditorFeatures/CSharpTest/StringCopyPaste/StringCopyPasteCommandHandlerTests.cs
  Restore
  Add docs
  Fix
  Update Tools|Options code ordering to match waht is in the UI
  Use correct directory for loghub logs (dotnet#61104)
  Move usings on paste off the UI thread (dotnet#61092)
  Create shared helper to handle finding extensions in analyzer references
  Code style to convert byte arrays to UTF8 strings (dotnet#60647)
  Fixup
  Enable semantic token LSP tests + re-enable quick info tests (dotnet#61098)
  Simplify initialization logic
  Simplify common CWT pattern
  Simplify common CWT pattern
  Simplify common CWT pattern
  Simplify common CWT pattern
  Simplify common CWT pattern
  ...
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants