Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap 17.3 P2 #61618

Merged
merged 1,104 commits into from
Jun 1, 2022
Merged

Snap 17.3 P2 #61618

merged 1,104 commits into from
Jun 1, 2022

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Jun 1, 2022

Merge main-vs-deps to release/dev17.3

sharwell and others added 30 commits May 13, 2022 10:11
It's valid for an input to be modified causing a downstream input to be removed (for example a syntax tree can change what is in it, leading to the downstream node not generating something). 

//cc @jkoritzinsky in case I'm missing something obvious.
More SyntaxContext sharing among CompletionProviders
* Fix several LSP completion kind mappings

* Extension method
Fix crash when a multi-line raw literal becomes a skipped token.
Add an UWP OptProf test for IDE
…rmatter. (#60522)

* Implement IDkmClrFullNameProvider2 in Roslyn's ResultProvider Formatter.

Issue:
- Debugger added IDkmClrFullNameProvider2 API with https://devdiv.visualstudio.com/DevDiv/_git/Concord/pullrequest/301518
- It is currently temporarily implement in Concord, needs to be implemented in Roslyn so implementation can be removed from Concord.

Changes:
1. Formatter:
- Implement IDkmClrFullNameProvider2. It has 2 methods, one to format local names and the other given field metadata.
- Currently only implemented for C#. I'm not that familiar with VB and the GeneratedNames stuff in VB needs some splitting and moving around to get working.

2. Unit tests:
- Add unit tests for the common cases of hoisted locals, synthesized locals, etc.

3. Versions.props:
Update MicrosoftVSSDKVSDConfigToolVersion to a newer version which recognizes IDkmClrFullNameProvider2.

* PR feedback - fix casing of MetadataImport

* PR feedback - move GetOriginalLocalVariableName, GetOriginalFieldName back to CSharpFormatter

Co-authored-by: Ramkumar Ramesh <ramram@microsoft.com>
Show not keyword (and all other stuff) after and & or when they are treated as identifiers
…d-members

Merge main to features/required-members
tmat and others added 5 commits May 31, 2022 12:39
…1356)

* Implements support for adding and removing await/yield return in C# async, iterator and async iterator methods.

* Fix syntax node associated with BoundTryStatement created from using syntax
@Cosifne Cosifne requested review from 333fred, JoeRobich and a team as code owners June 1, 2022 00:06
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@Cosifne Cosifne enabled auto-merge (squash) June 1, 2022 00:23
@Cosifne Cosifne merged commit 63fb830 into release/dev17.3 Jun 1, 2022
@Cosifne Cosifne deleted the merge/17.3P2Snap branch June 1, 2022 03:05
@Cosifne Cosifne restored the merge/17.3P2Snap branch June 1, 2022 04:47
Cosifne added a commit that referenced this pull request Jun 1, 2022
@Cosifne Cosifne deleted the merge/17.3P2Snap branch June 1, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.