-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snap 17.3 P2 #61618
Merged
Merged
Snap 17.3 P2 #61618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's valid for an input to be modified causing a downstream input to be removed (for example a syntax tree can change what is in it, leading to the downstream node not generating something). //cc @jkoritzinsky in case I'm missing something obvious.
More SyntaxContext sharing among CompletionProviders
* Fix several LSP completion kind mappings * Extension method
Fix crash when a multi-line raw literal becomes a skipped token.
Add an UWP OptProf test for IDE
…abadi/roslyn into smartCopyPasteLineCopy
Merge release/dev17.3 to main
…rmatter. (#60522) * Implement IDkmClrFullNameProvider2 in Roslyn's ResultProvider Formatter. Issue: - Debugger added IDkmClrFullNameProvider2 API with https://devdiv.visualstudio.com/DevDiv/_git/Concord/pullrequest/301518 - It is currently temporarily implement in Concord, needs to be implemented in Roslyn so implementation can be removed from Concord. Changes: 1. Formatter: - Implement IDkmClrFullNameProvider2. It has 2 methods, one to format local names and the other given field metadata. - Currently only implemented for C#. I'm not that familiar with VB and the GeneratedNames stuff in VB needs some splitting and moving around to get working. 2. Unit tests: - Add unit tests for the common cases of hoisted locals, synthesized locals, etc. 3. Versions.props: Update MicrosoftVSSDKVSDConfigToolVersion to a newer version which recognizes IDkmClrFullNameProvider2. * PR feedback - fix casing of MetadataImport * PR feedback - move GetOriginalLocalVariableName, GetOriginalFieldName back to CSharpFormatter Co-authored-by: Ramkumar Ramesh <ramram@microsoft.com>
Show not keyword (and all other stuff) after and & or when they are treated as identifiers
…d-members Merge main to features/required-members
…1356) * Implements support for adding and removing await/yield return in C# async, iterator and async iterator methods. * Fix syntax node associated with BoundTryStatement created from using syntax
Merge main to main-vs-deps
Merge main to main-vs-deps
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
333fred
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main-vs-deps to release/dev17.3