-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter symbol first before creating InheritanceMargin target #61911
Merged
Cosifne
merged 10 commits into
dotnet:main
from
Cosifne:dev/shech/InheritanceMarginTargetFilter
Jun 21, 2022
Merged
Filter symbol first before creating InheritanceMargin target #61911
Cosifne
merged 10 commits into
dotnet:main
from
Cosifne:dev/shech/InheritanceMarginTargetFilter
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosifne
force-pushed
the
dev/shech/InheritanceMarginTargetFilter
branch
from
June 15, 2022 23:17
e34b0b0
to
d9d9eb0
Compare
src/Features/Core/Portable/InheritanceMargin/AbstractInheritanceMarginService_Helpers.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/InheritanceMargin/AbstractInheritanceMarginService_Helpers.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/InheritanceMargin/AbstractInheritanceMarginService_Helpers.cs
Outdated
Show resolved
Hide resolved
Done with pass. |
Tag @CyrusNajmabadi to have a second review |
src/Features/Core/Portable/InheritanceMargin/AbstractInheritanceMarginService_Helpers.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jun 21, 2022
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1514769
The reason for the IndexOutOfRange exception is because there is no target for a given
InheritanceMarginItem
.And it happens because
Code defects here
At all the similar places, it creates an InheritanceMarginItem when there are base type symbols or derived type symbols.
However, there is another filtering later, which is checking if the symbol could be navigable.
And if this filter gets all the symbols out, then we end up with an InheritanceMarginItem with no targets.
This really happens in cases like
here for
B
,C
is a hidden place, so it would be filtered by this line And forB
, it has an empty InheritanceMarginItem.The fix is:
InheritanceMarginItem
is created, we should check the target items is not empty.