Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move option code over to using snapshots #62959

Merged
merged 9 commits into from
Jul 27, 2022
Merged

Move option code over to using snapshots #62959

merged 9 commits into from
Jul 27, 2022

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review July 27, 2022 04:06
@CyrusNajmabadi CyrusNajmabadi requested review from 333fred, JoeRobich and a team as code owners July 27, 2022 04:06
@runfoapp runfoapp bot mentioned this pull request Jul 27, 2022
Open
jasonmalinowski
jasonmalinowski approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great; I'm not sure if there's a follow-up though for the DelegatingCodeActionOptionsProvider type that had one change that looked a bit suspicious.

src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/CodeFixes/CodeActionOptions.cs Show resolved Hide resolved
@CyrusNajmabadi CyrusNajmabadi merged commit 5946cd9 into dotnet:main Jul 27, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the banAPI5 branch July 27, 2022 19:32
@ghost ghost added this to the Next milestone Jul 27, 2022
@allisonchou allisonchou mentioned this pull request Aug 3, 2022
Closed
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@333fred 333fred Awaiting requested review from 333fred 333fred is a code owner

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @jasonmalinowski @dibarbet