Rename LifetimeAnnotationAttribute to ScopedRefAttribute and simplify
#63009
Conversation
| @@ -334,7 +334,7 @@ static AttributeDescription() | |||
| private static readonly byte[][] s_signaturesOfNullableAttribute = { s_signature_HasThis_Void_Byte, s_signature_HasThis_Void_SzArray_Byte }; | |||
| private static readonly byte[][] s_signaturesOfNullableContextAttribute = { s_signature_HasThis_Void_Byte }; | |||
| private static readonly byte[][] s_signaturesOfNativeIntegerAttribute = { s_signature_HasThis_Void, s_signature_HasThis_Void_SzArray_Boolean }; | |||
| private static readonly byte[][] s_signaturesOfLifetimeAnnotationAttribute = { s_signature_HasThis_Void_Boolean_Boolean }; | |||
| private static readonly byte[][] s_signaturesOfScopedRefAttribute = { s_signature_HasThis_Void }; | |||
| } | ||
| else | ||
| { | ||
| scope = scopeOpt.GetValueOrDefault(); | ||
| if (typeWithAnnotations.Type.IsRefLikeType) |
There was a problem hiding this comment.
Minor: Consider collapsing to else if. #Closed
There was a problem hiding this comment.
That was intentional, but I don't feel very strongly about it ;-)
Consider removing if not needed. In reply to: 1198403939 Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/SynthesizedEmbeddedLifetimeAnnotationAttributeSymbol.cs:9 in 35ff572. [](commit_id = 35ff572, deletion_comment = False) |
| }); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ExplicitAttribute_MissingConstructor() |
| var parameter = method.Parameters[0]; | ||
| Assert.Equal(DeclarationScope.ValueScoped, parameter.Scope); | ||
|
|
||
| method = comp.GetMember<MethodSymbol>("A.F3"); |
|
Consider renaming files as well:
In reply to: 1198411628 |
|
I intentionally didn't rename them yet to minimize risk of conflicts. We can do that later In reply to: 1198411628 |
| Diagnostic(ErrorCode.WRN_UnreferencedEvent, "E").WithArguments("Program.E").WithLocation(7, 58)); | ||
| // (3,10): error CS0592: Attribute 'ScopedRef' is not valid on this declaration type. It is only valid on 'parameter' declarations. | ||
| // [module: ScopedRef] | ||
| Diagnostic(ErrorCode.ERR_AttributeOnBadSymbolType, "ScopedRef").WithArguments("ScopedRef", "parameter").WithLocation(3, 10), |
There was a problem hiding this comment.
Diagnostic(ErrorCode.ERR_AttributeOnBadSymbolType, "ScopedRef").WithArguments("ScopedRef", "parameter").WithLocation(3, 10),
Ideally, this test should use a definition of ScopedRefAttributes with AttributeTargets.All rather than AttributeTargets.Parameter, so we can ensure we're reporting errors for the use in source (when #62124 is fixed) rather than for incorrect target.
It's not blocking though. #Pending
| SynthesizedParameterSymbol.Create(m, TypeWithAnnotations.Create(boolType), 1, RefKind.None)), | ||
| (f, s, p) => GenerateConstructorBody(f, s, p))); | ||
| getParameters: m => ImmutableArray<ParameterSymbol>.Empty, | ||
| getConstructorBody: (f, s, p) => { })); |
There was a problem hiding this comment.
Nit: discards? #Pending
…and simplify (dotnet#63009)" This reverts commit 7915cb7.
Revert "Rename `LifetimeAnnotationAttribute` to `ScopedRefAttribute` and simplify (#63009)"
Fixes #62838