Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add threading asserts to rename #63068

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Add threading asserts to rename #63068

merged 2 commits into from
Jul 29, 2022

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@ryzngard
Copy link
Contributor

let me know when this is ready for review

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review July 29, 2022 20:41
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 29, 2022 20:41
@CyrusNajmabadi
Copy link
Member Author

@ryzngard Ready :)

ryzngard
ryzngard reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a fan of added clarity 😊

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge July 29, 2022 21:48
@CyrusNajmabadi CyrusNajmabadi merged commit 21bc27c into dotnet:main Jul 29, 2022
@ghost ghost added this to the Next milestone Jul 29, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the renameThreadingAsserts branch July 30, 2022 17:06
@allisonchou allisonchou mentioned this pull request Aug 3, 2022
Closed
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @ryzngard @JoeRobich @dibarbet