Wait for reverse oop-to-host asset-sync calls to finish before the last oop call returns back to the host. #63122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st oop call returns back to the host.
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
Aug 2, 2022
src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.InFlightSolution.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Aug 2, 2022
| /// unpinning the solution on the host) while the solution-computation tasks are still running and may still | ||
| /// attempt to call into the host. | ||
| /// </summary> | ||
| public ImmutableArray<Task> DecrementInFlightCount_NoLock() |
There was a problem hiding this comment.
i was considering having this return a Task that represented what the caller should await on. however, we don't want this call awaited while in the state-lock, so that could be very confusing. instead, we want this to run synchronously, clean up everything properly, then return the Task/Tasks the caller should await outsdie of hte lock. So this is a bit clearer in that regard (imo).
dibarbet
approved these changes
Aug 2, 2022
src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.InFlightSolution.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Aug 2, 2022
src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.InFlightSolution.cs
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Aug 2, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.